Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3DS tests #92

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix 3DS tests #92

merged 1 commit into from
Feb 27, 2024

Conversation

nbierdeman
Copy link
Contributor

@nbierdeman nbierdeman commented Feb 27, 2024

Description

This PR fixes an issue that was introduced with the latest versions of @paypal/sdk-client.

Why are we making these changes?

CI is failing for new PRs to paypal-common-components.

Reproduction Steps

Run npm run karma with v4.0.181 or later of @paypal/sdk-client.

Screenshots

Works with v4.0.180:
Screenshot 2024-02-26 at 3 13 48 PM

Breaks with v4.0.181 or later:
Screenshot 2024-02-26 at 3 16 00 PM

Dependent Changes

Unblocking this PR for @mchoun.

Attribution

@jshawl figured this out first here. 🙏

@nbierdeman nbierdeman requested a review from a team as a code owner February 27, 2024 14:45
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (00dbeba) to head (664bc90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files           7        7           
  Lines         152      152           
  Branches       35       35           
=======================================
  Hits           90       90           
  Misses         52       52           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SancSalix SancSalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@nbierdeman nbierdeman merged commit 951a575 into main Feb 27, 2024
3 checks passed
@nbierdeman nbierdeman deleted the fix-3ds-tests branch February 27, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants