fix overlay rtl direction #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshawl
commented
Feb 28, 2024
| @@ -178,6 +178,7 @@ export function Overlay({ | |||
| <html> | |||
| <body> | |||
| <div | |||
| dir="auto" | |||
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 7 7
Lines 152 152
Branches 35 35
=======================================
Hits 90 90
Misses 52 52
Partials 10 10 ☔ View full report in Codecov by Sentry. |
jshawl
commented
Feb 28, 2024
| @@ -193,7 +194,7 @@ export function Overlay({ | |||
| )} | |||
| {!fullScreen && ( | |||
| <div class="paypal-checkout-modal"> | |||
| <div class="paypal-checkout-logo"> | |||
| <div class="paypal-checkout-logo" dir="ltr"> | |||
There was a problem hiding this comment.
the logo should always be left to right:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where RTL languages are not being displayed in the correct direction.
Before:
After:
