Update publish to NPM script #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethmv
approved these changes
Apr 26, 2024
jshawl
approved these changes
Apr 26, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@paypal/common-components", | |||
| "version": "1.0.45", | |||
| "version": "1.0.46", | |||
There was a problem hiding this comment.
I think this version change won't cause a problem but might be good to back it out anyway
There was a problem hiding this comment.
When running the npm publish github action off main I got this error: https://github.com/paypal/paypal-common-components/actions/runs/8853608567/job/24314849632
Will merging this PR, resolve that without manually bumping the version?
| @@ -1,4 +1,22 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Running `npm version` will run through the other version lifecycle scripts | |||
| npm version ${1-patch}; | |||
There was a problem hiding this comment.
I don't think anything... 🤔
There was a problem hiding this comment.
${1-path} resolves to patch
The syntax seems to be doing some type of subsitution but it seems unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the npm publish github action to release an alpha branch of the package if its not run off the repos main branch.