pep8 fixes #1
Merged
pep8 fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Plumb memory leaks in allocation * Don't cast return value from malloc * Remove unused variables * No more register keyword; is a no-op in modern compilers * Cosmetic changes
Make ball tree code safer and 64-bit clean
Copy editing in developers' docs by Lars
…n grid_search That would make it easier to allow using system-wide installed joblib on Debian installations which provide only rudimentary externals/joblib/__init__.py Please cherry-pick into 0.8.X
RF: use joblib.logger submodule itself while accessing its function in grid_search
small typo in docs
…learn into jakevdp-balltree-wrapper
* use size_t consistently * use auto_ptr to prevent memory leaks * some minor fixes
The user can now choose either Mean Squared Error, Root Mean Squared Error or Sum of Squared Errors through a keyword. Others types of error may be implemented depending on future needs.
I feel it is a little hacky since I copy init at the very begining, not in "_init_centroids". But in this function, X_mean would not be available. And I like this solution better than adding another argument to _init_centroids.
…with k_means function. Don't know if this is the desirable default.
…. Now fails on initialization bug.
pre_dispatch limits the amount of jobs spawn, and thus puts a bound on memory usage.
Accept list arguments in grid_search
Fixing issue 82 and 183
… pberkes-mldata
|
Actually the pep8 fixes is just the last checking. All other changesets have happened on master since your forked your branch. Please feel free to merge all of them as well to keep you branch close to the current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some small pep8 fixes for your branch.