flac, isomp4, mkv: optimize length detection by using byte_len() instead of seeking #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of seeking Replace seeking to end of file with byte_len() call to get total stream length. This improves performance when streaming files by avoiding an unnecessary seek operation. The change maintains the same functionality while being more efficient, especially for remote/streaming files where seeks are expensive. Also fixes some minor code formatting issues with else clauses.
roderickvd
added a commit
to roderickvd/pleezer
that referenced
this pull request
Jan 16, 2025
Uses a patched version of Symphonia that improves seeking performance in FLAC and MP4 files by using the known file byte length instead of seeking to the end of file to determine length. This is a temporary patch that will be removed once pdeljanov/Symphonia#340 is merged upstream.
|
Hi @roderickvd, yeah, that's the way it should've been. Nice find! The reason you got so many formatting changes is because we need the nightly rustfmt to use the brace style option. Are you able to run that with By the way, please keep an eye on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace seeking to end of file with
byte_len()call to get total stream length. This improves performance when streaming files by avoiding an unnecessary seek operation. The change maintains the same functionality while being more efficient, especially for remote/streaming files where seeks are expensive.As used in
pleezer, previously seeking would block the application until the full file was downloaded, even if the position seemed to was already buffered. With this change, such seeks are nearly instantaneous.Optionally, we could first try
byte_len()and fall back to seeking to the end whenbyte_len()is not available.The actual change is just three lines, but my editor automatically fixed some minor code formatting issues with else clauses. Nothing more than
rustfmt.