-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: correct default cache path #646
Conversation
I suspect it makes a difference whether your workflow contains |
@deining You're right, I modified the PR a little more to cover those two use cases. |
Hello @razonyang ! I'm reaching you because I've also pushed a PR on this repo, trying to fix this with an another approach. What are your thoughts? |
@Zer0xxxx GitHub actions can be ran on Windows, there is no |
Oh, you're right. I'm dumb, haha! I don't think this is necessarily a problem, though, since I've specified in the documentation snippets that the action runs on Ubuntu-22.04 (just above the Documenting absolutely every conceivable use seems to me to be rather complicated, and confusing. Are there any use cases that I might miss where launching the action in a workflow rather on Windows than on Ubuntu is mandatory? |
Maybe tests purpose, to make sure the theme works on all supported platforms (Linux, macOS and Windows). |
Hmm... Using a matrix, then? |
👀 |
Should I nail it too? 😉 |
Lack of time to resolve conflicts, and env approach is not bad, closing this for now. |
May fixes #645, but I'm not sure, since I didn't find any information about this cache path after searching docs, @deining would you mind checking if this PR is OK?