Blanklines: Revert pre changes, add testcases #74
+21
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to performance concerns (And the fact that the output source is nearly perfect without it anyway) I'm submitting this for a 30% performance improvement and some more rigorous testing for blanklines mode
jnvsor
added a commit
that referenced
this pull request
Feb 2, 2016
Blanklines: Revert pre changes, add testcases, fix #70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70 (Introduced in dd5563b v3.0.1)
Has a slight detrimental effect on output HTML but doesn't effect the browser's rendered output, and is 30% faster. Additionally, current master not only eats newlines but the entire line before unindented pre tags so it's an improvement.
I suggested an alternative in bcccb18 for an extra 5% speedup but it adds some extra artefacts. If someone's using blanklines mode they're probably willing to put up the rare missing newline more than the 100% drop in performance suggested in #72