Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): Added Uzbek translations #4059

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

HBarotov
Copy link
Contributor

@HBarotov HBarotov commented Aug 22, 2024

Submitting Pull Requests

I am a native Uzbek speaker. I am using this package in my projects, so I thought it would be a good idea to translate it for myself & other potential users.

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

coverage: 96.117%. remained the same
when pulling d2c9398 on HBarotov:feat-uzbek-translations
into 636e5e7 on pennersr:main.

@pennersr
Copy link
Owner

Thanks! Though, it seems to break the build:

Execution of msgfmt failed: /home/runner/work/django-allauth/django-allauth/allauth/locale/uz/LC_MESSAGES/django.po:619:9: syntax error
/home/runner/work/django-allauth/django-allauth/allauth/locale/uz/LC_MESSAGES/django.po:619: keyword "Sizga" unknown
/home/runner/work/django-allauth/django-allauth/allauth/locale/uz/LC_MESSAGES/django.po:715:2: syntax error
/home/runner/work/django-allauth/django-allauth/allauth/locale/uz/LC_MESSAGES/django.po:715: keyword "Siz" unknown
/home/runner/work/django-allauth/django-allauth/allauth/locale/uz/LC_MESSAGES/django.po:1306:9: syntax error
/home/runner/work/django-allauth/django-allauth/allauth/locale/uz/LC_MESSAGES/django.po:1306: keyword "last_used" unknown

Can you look into those?

@HBarotov
Copy link
Contributor Author

Yeah, sorry the issue was I somehow confused double quotes and similar-looking Unicode quotes. The issue is fixed now.

@pennersr
Copy link
Owner

Thanks, there is one more though:

django.po:976: 'msgstr' is not a valid Python format string, unlike 'msgid'. Reason: In the directive number 1, the character 'k' is not a valid conversion specifier.

@HBarotov
Copy link
Contributor Author

Yeah, sorry for the less-than-acceptable work, the second time opening up a PR.

@pennersr
Copy link
Owner

No worries, thanks for contributing.

@pennersr pennersr merged commit b8b06c3 into pennersr:main Aug 22, 2024
36 checks passed
@HBarotov HBarotov deleted the feat-uzbek-translations branch August 22, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants