Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the type attribute from <script> tags #4067

Merged

Conversation

d9pouces
Copy link
Contributor

Submitting Pull Requests

The “type” attribute is unnecessary for JavaScript resources. The default type for <script> tags is JavaScript, so you don’t need to include the type for JS resources.

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

@coveralls
Copy link

Coverage Status

coverage: 96.117%. remained the same
when pulling 710a9bb on d9pouces:4066-remove-type-attribute-from-script
into 83fa927 on pennersr:main.

@pennersr pennersr merged commit 9f250a1 into pennersr:main Aug 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants