[BACKLOG-43081] - import-export.sh working with global/local #9846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abryant-hv
commented
Mar 4, 2025
abryant-hv
commented
- copy shared objects from the RepositoryBowl to the TransMeta or JobMeta before export in StreamToJobNodeConverter and StreamToTransNodeConverter.
- Strip object ids from meta before exporting
- move shared objects to RepositoryBowl and fix database connections on import in StreamToJobNodeConverter and StreamToTransNodeConverter
- new API to list names of used database connections from AbstractMeta (more efficient than asking the meta about each connection)
- SharedObjectUtil methods:
- copy used db and all other shared objects into meta from a (Repository) Bowl, for export
- moved patchDatabaseConnections here to use in other import mechanisms
- stripObjectIds, for use before export
- copy shared objects from the RepositoryBowl to the TransMeta or JobMeta
before export in StreamToJobNodeConverter and StreamToTransNodeConverter.
- Strip object ids from meta before exporting
- move shared objects to RepositoryBowl and fix database connections on import
in StreamToJobNodeConverter and StreamToTransNodeConverter
- new API to list names of used database connections from AbstractMeta
(more efficient than asking the meta about each connection)
- SharedObjectUtil methods:
- copy used db and all other shared objects into meta from a (Repository)
Bowl, for export
- moved patchDatabaseConnections here to use in other import mechanisms
- stripObjectIds, for use before export
pdesai16
reviewed
Mar 6, 2025
| DatabaseManagementInterface targetManager = targetMeta.getSharedObjectManager( DatabaseManagementInterface.class ); | ||
|
|
||
| Set<String> usedNames = targetMeta.getUsedDatabaseConnectionNames(); | ||
| for ( String name : usedNames ) { |
There was a problem hiding this comment.
What happens to the used connections that are in source but not in destination
There was a problem hiding this comment.
They get copied to targetManager. I'm not sure what the question is here.
pdesai16
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.