[BACKLOG-43080] - fix name collisions on edit and import #9853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abryant-hv
commented
Mar 7, 2025
abryant-hv
commented
- stop clearing object Id in PartitionSchema.clone
- stop checking for existing object in PartitionDelegate.elementToDataNode (now handled elsewhere)
- standardize on finding existing object ids in a case-insensitive manner for all shared object types in the repository
- Fix Spoon Delegate handling for checking for changed case. Only remove from the backing manager if the name changed more than just case.
- Clear the object ID if we're removing and adding to the manager so the repository sees the new object as a new object.
- stop clearing object Id in PartitionSchema.clone - stop checking for existing object in PartitionDelegate.elementToDataNode (now handled elsewhere) - standardize on finding existing object ids in a case-insensitive manner for all shared object types in the repository - Fix Spoon Delegate handling for checking for changed case. Only remove from the backing manager if the name changed *more* than just case. - Clear the object ID if we're removing and adding to the manager so the repository sees the new object as a new object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.