- #PXC-501: galera_split_brain TC failing with following assertion intermittently #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction KeyPart::matches (), which compares the two keys, because one of those keys is empty (the field "version" in this key contains the value "EMPTY"). The key to a locally created transaction may be empty until it is completed, but the current code does not allow this and trying looking for a key in the certification index. However, technically this key would fit to all the elements of the certification index. Therefore, the key comparison function in the KeyPart class has assertion to detect such incorrect comparisons, which leads to the PXC-501 error. However, the fact of the empty key cannot be inserted in the certification index; therefore, we can just skip it immediately.
| @@ -118,6 +118,17 @@ galera::Certification::purge_for_trx_v3(TrxHandle* trx) | |||
| for (long i = 0; i < keys.count(); ++i) | |||
| { | |||
| const KeySet::KeyPart& kp(keys.next()); | |||
|
|
|||
There was a problem hiding this comment.
I am wondering what causes local key to empty. My investigation few days back suggested that only if you append_key trx is forwarded for certification.
Purge action explain the intermediate failure.
Can you write a small tcs where-in you see local trx generating an empty key part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
galera_split_brain TC failing with assertion intermittently in the function KeyPart::matches (), which compares the two keys, because one of those keys is empty (the field "version" in this key contains the value "EMPTY").
The key to a locally created transaction may be empty until it is completed, but the current code does not allow this and trying looking for a key in the certification index. However, technically this key would fit to all the elements of the certification index. Therefore, the key comparison function in the KeyPart class has assertion to detect such incorrect comparisons, which leads to the PXC-501 error. However, the fact of the empty key cannot be inserted in the certification index; therefore, we can just skip it immediately.
Related PXC patch here: percona/percona-xtradb-cluster#121