Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBM-1339 Extended PBM compatibility table #186

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

nastena1606
Copy link
Collaborator

@nastena1606 nastena1606 commented Jun 20, 2024

Added links to it

modified: docs/details/versions.md
modified: docs/index.md
modified: docs/install/repos.md
modified: docs/install/source.md
modified: docs/install/tarball.md
modified: docs/installation.md
modified: mkdocs-base.yml

Added:

  • warning to mention to use old PBM versions with EOL-ed MongoDB versions (even if latest PBM version could still work in this case)

Copy link

render bot commented Jun 20, 2024

@sleto-it
Copy link
Contributor

Hi @nastena1606, thanks for working on this, and for linking the compatibility matrix in multiple points of the doc.
From my point of view (user perspective) the table is clear - I have clear view of which MongoDB versions I can use with specific PBM versions.

It might need validation from Engineering, I am validating only the user interface here.

One comment, I would suggest bullet points inside the table, for better clarity. I am pushing this change, but feel free to revert if you do not like it. I am reporting below how it looks like after a local compilation:

Before:

before

Now:

now

Copy link
Contributor

@sleto-it sleto-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit to propose using bullet points inside the table for better clarify. OK from my side, from a user perspective. Might need additional validation from Engineering wrt checking the specific versions - otherwise OK to merge. Thanks

@nastena1606
Copy link
Collaborator Author

Awesome, thank you @sleto-it !

Copy link
Member

@boris-ilijic boris-ilijic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I checked only recent PBM versions (2.4 and 2.5) because I do not have an overview of the older ones.

docs/details/versions.md Outdated Show resolved Hide resolved
Added links to it

modified:   docs/details/versions.md
	modified:   docs/index.md
	modified:   docs/install/repos.md
	modified:   docs/install/source.md
	modified:   docs/install/tarball.md
	modified:   docs/installation.md
	modified:   mkdocs-base.yml
@nastena1606 nastena1606 force-pushed the PBM-1339-PBM-compatibility-matrix branch from af6c517 to eedf001 Compare June 21, 2024 11:22
modified:   docs/details/versions.md
docs/details/versions.md Outdated Show resolved Hide resolved
@nastena1606 nastena1606 merged commit 363bad6 into main Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants