-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PBM-1339 Extended PBM compatibility table #186
Conversation
Your Render PR Server URL is https://pbm-docs-pr-186.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cpq33co8fa8c73b2su9g. |
Hi @nastena1606, thanks for working on this, and for linking the compatibility matrix in multiple points of the doc. It might need validation from Engineering, I am validating only the user interface here. One comment, I would suggest bullet points inside the table, for better clarity. I am pushing this change, but feel free to revert if you do not like it. I am reporting below how it looks like after a local compilation: Before: Now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit to propose using bullet points inside the table for better clarify. OK from my side, from a user perspective. Might need additional validation from Engineering wrt checking the specific versions - otherwise OK to merge. Thanks
Awesome, thank you @sleto-it ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I checked only recent PBM versions (2.4 and 2.5) because I do not have an overview of the older ones.
Added links to it modified: docs/details/versions.md modified: docs/index.md modified: docs/install/repos.md modified: docs/install/source.md modified: docs/install/tarball.md modified: docs/installation.md modified: mkdocs-base.yml
af6c517
to
eedf001
Compare
modified: docs/details/versions.md
Co-authored-by: Santo <[email protected]>
Added links to it
modified: docs/details/versions.md
modified: docs/index.md
modified: docs/install/repos.md
modified: docs/install/source.md
modified: docs/install/tarball.md
modified: docs/installation.md
modified: mkdocs-base.yml
Added: