Add pre-commit routines for prettier formatting on Xacro, launch and package XML files #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a pre-commit routine for prettier formatting on Xacro, launch and package XML files. Resolves #56
You must run
npm install --save-dev prettier @prettier/plugin-xml
prior topre-commit run --all-files
to run prettier with the XML plugin.Note to reviewers: You don't need to read all the thousands of changed lines, just skim through and notice that our Xacro is actually readable now :)
Testing procedure
This PR does not introduce any fundamental changes to the behavior of the code, it just updates formatting
Before opening a pull request
pre-commit run --all-files
pylint --recursive=y --rcfile=.pylintrc .
. All warnings butfixme
must be addressed.Before Merging
Squash & Merge