Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trajectory splitting functions. #290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

psigen
Copy link
Member

@psigen psigen commented Apr 4, 2016

This PR adds a few utility functions for splitting trajectories by time.

@@ -1683,8 +1770,7 @@ def GetLinearCollisionCheckPts(robot, traj, norm_order=2, sampling_func=None):
waypoint = traj.GetWaypoint(i)
q1 = traj_cspec.ExtractJointValues(waypoint, robot, dof_indices)
dq = numpy.abs(q1 - q0)
max_diff_float = numpy.max( numpy.abs(q1 - q0) / q_resolutions)


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-emptive explanation: this variable was totally unused and my auto-linter compelled me to destroy it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My auto-linter often compels me to destroy things gently muttering "Now I am become Death, the destroyer of worlds."

On Apr 4, 2016, at 11:05 AM, Pras Velagapudi [email protected] wrote:

In src/prpy/util.py:

@@ -1683,8 +1770,7 @@ def GetLinearCollisionCheckPts(robot, traj, norm_order=2, sampling_func=None):
waypoint = traj.GetWaypoint(i)
q1 = traj_cspec.ExtractJointValues(waypoint, robot, dof_indices)
dq = numpy.abs(q1 - q0)

- max_diff_float = numpy.max( numpy.abs(q1 - q0) / q_resolutions)

Pre-emptive explanation: this variable was totally unused and my auto-linter compelled me to destroy it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@psigen psigen force-pushed the feature/trajectory_split branch from aad50ac to 3baaf7b Compare April 4, 2016 16:12
@mkoval
Copy link
Member

mkoval commented Apr 4, 2016

Could you add one or two basic tests for each function?

@psigen
Copy link
Member Author

psigen commented Apr 6, 2016

Good point, I will try to add some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants