Add support for Pikatea GB4 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
commented
Dec 26, 2022
| @@ -211,6 +218,11 @@ class StreamDeck { // eslint-disable-line | |||
| device.productId === 0x0080) { | |||
| return device; | |||
| } | |||
| } else if ( | |||
There was a problem hiding this comment.
the WET-ness of this function stood out to me before (getPreviousDevice repeating a bunch from getDevice).. and this new branch exacerbates it a bit..
so I tried to DRY it up.. but tbh I don't love the result: paulirish/StreamDeck-Meet@macropad...dry-er-filters
I'm pretty confident the match-any-filter impl I have matches up completely with the spec, so it does seem very future-friendly. But it isn't nice to look at.
Your call. I could totally go either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pikatea GB4 is this badboy:
I got one of these primarily to control meet, and integrating it into this ext was pretty straightforward. (Though there are zero HID docs for the device... but once I explored it a bit I feel happy with the implementation choices below)
Lemme know what ya think.