Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct php-http/httplug version #294

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

reyostallenberg
Copy link
Contributor

Correct php-http/httplug version form "^1.0" to "^2.0" to reflect an installable Your Final composer.json

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

What's in this PR?

When using the example on this page you'll get:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - php-http/mock-client[dev-master, 1.5.0] require php-http/httplug ^2.0 -> found php-http/httplug[dev-master, v2.0.0, 2.1.0, 2.2.0, 2.x-dev (alias of dev-master)] but it conflicts with your root composer.json require (^1.0).
    - php-http/mock-client 1.x-dev is an alias of php-http/mock-client dev-master and thus requires it to be installed too.
    - Root composer.json requires psr/http-client-implementation ^1.0 -> satisfiable by php-http/mock-client[dev-master, 1.5.0, 1.x-dev (alias of dev-master)].

Why?

This makes the example directly usable

Correct php-http/httplug version form "^1.0" to "^2.0" to reflect an installable Your Final ``composer.json``
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit 0412c6a into php-http:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants