ext/pdo: Refactor do_fetch() when fetch mode is PDO::FETCH_COLUMN #17394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
pdo-do-fetch-column-refactoring
branch
from
cbe14aa to
ced646c
Compare
nielsdos
reviewed
Feb 10, 2025
|
Will do then, I think this initially started as Kamil was wondering why I had split off the column logic. |
Girgias
force-pushed
the
pdo-do-fetch-column-refactoring
branch
from
ced646c to
e2b069e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not even sure I got the logic right, as the current processing is hella confusing.