Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-process.rst to fix two typos #9

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

DanielEScherzer
Copy link
Contributor

No description provided.

@cmb69
Copy link
Member

cmb69 commented Sep 3, 2024

Huh! Not sure why CI complains.

@DanielEScherzer
Copy link
Contributor Author

I think its because of #8 not being done yet, since the failures are from multiple files:

coding-standards-and-naming.rst is not correctly formatted!
feature-proposals.rst is not correctly formatted!
release-process.rst is not correctly formatted!
security-classification.rst is not correctly formatted!
security-policies.rst is not correctly formatted!

@derickr
Copy link
Member

derickr commented Sep 3, 2024 via email

@cmb69
Copy link
Member

cmb69 commented Sep 3, 2024

@derickr, #8 has not been merged, but the CI check is already in place.

@DanielEScherzer
Copy link
Contributor Author

DanielEScherzer commented Sep 17, 2024

That's odd. They were working earlier. I'll have a look tomorrow.

@derickr any updates? Maybe this could be merged despite not passing CI

@derickr
Copy link
Member

derickr commented Sep 17, 2024 via email

@derickr
Copy link
Member

derickr commented Sep 18, 2024

Ah right, could you rebase this? It should work then. (it conflicts now)

@DanielEScherzer
Copy link
Contributor Author

Ah right, could you rebase this? It should work then. (it conflicts now)

Done

@cmb69 cmb69 merged commit 9d9ba77 into php:main Sep 19, 2024
1 check passed
@cmb69
Copy link
Member

cmb69 commented Sep 19, 2024

Thank you!

@DanielEScherzer DanielEScherzer deleted the patch-1 branch September 23, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants