[WIP] GitHub integration

[saundefined]

Changed

• GitHub requests use a header instead of access_token

Added

• Possibility to link GitHub profile

SQL migration

ALTER TABLE `users` ADD `github` VARCHAR(39) NULL AFTER `username`;
ALTER TABLE `users` ADD UNIQUE(`github`);

[johannes]

I haven't tested it, but looking over it seems fine.when applying this needs to be coordinated with schema changes and should be tested once master synced.

[nikic]

This is currently using scope=repo. That makes sense to repo administration, but is way too much just to link accounts.

[saundefined]

@nikic,

This is currently using scope=repo. That makes sense to repo administration, but is way too much just to link accounts.

I don't remove the repo administration section, if a user is in GITHUB_PHP_OWNER_TEAM_ID, it still can do it.
Also, token saved in the session, only if the user in the owners' team.

[nikic]

@nikic,

This is currently using scope=repo. That makes sense to repo administration, but is way too much just to link accounts.

I don't remove the repo administration section, if a user is in GITHUB_PHP_OWNER_TEAM_ID, it still can do it.
Also, token saved in the session, only if the user in the owners' team.

What I meant here is that the user shouldn't need to grant PHP write access to all their public and private repos just to associate their GitHub account. We should only request minimal permissions for this purpose.

[saundefined]

We should only request minimal permissions for this purpose.

replaced with read:org, without it I can't check membership

[nikic]

Having looked at what this code did before ... I think we can just drop the repo management part entirely. What it currently implements will not work right now (because the team it assigns doesn't exist anymore), and this doesn't really seem like particularly useful functionality in the first place. I wasn't aware this tool existed and have always created repositories without it...

[saundefined]

@nikic, thank you!

Updated the logic:

• link accounts in any case;
• don't request additional scopes;
• removed creation of repositories.

If it's ok, after #12, I'll update the changed functions and ready for final review.

[Aaron-Junker]

Hi @saundefined. As you know I'm currently working on a RFC to create a global login system, that likely will use GitHub.

I just saw this PR and now I'm not sure if I should include this in the RFC and how, because it looks pretty finished, but it has no update since over a year.

[saundefined]

@Aaron-Junker, this PR proposes simply linking GitHub profiles to a PHP account.
It should not affect global auth :)

[Aaron-Junker]

@Aaron-Junker, this PR proposes simply linking GitHub profiles to a PHP account. It should not affect global auth :)

Ok.