Link to installation documentation and Windows downloads #1076
Conversation
|
🚀 Regression report for commit f252981 is at https://web-php-regression-report-pr-1076.preview.thephp.foundation |
|
🚀 Preview for commit f252981 can be found at https://web-php-pr-1076.preview.thephp.foundation |
downloads.php
Outdated
| <a href="/manual/en/install.unix.php">Installation instructions for Unix systems</a> | ||
| </li> | ||
| <li> | ||
| <a href="/manual/en/install.macosx.php">Installation instructions for macOS</a> |
There was a problem hiding this comment.
Maybe directly link to https://www.php.net/manual/install.macosx.packages.php?
There was a problem hiding this comment.
I think we want to link to the install page for macOS and Unix instead of direct to the packages, just to not push users too deep into the weeds. Those pages in the documentation should be cleaned up to put information about downloading binaries/packages before instructions on building from source.
downloads.php
Outdated
|
|
||
| <ul> | ||
| <li> | ||
| <a href="/manual/en/install.unix.php">Installation instructions for Unix systems</a> |
There was a problem hiding this comment.
Most of the installation instructions for Unix refer to manual builds. I think only https://www.php.net/manual/en/install.unix.debian.php is about packages. Besides that page needs an overhaul, we should at least have a respective page about Fedora/RHEL packages (yum). Maybe @remicollet is interested in this?
There was a problem hiding this comment.
Yeah, we can at least have a unix.yum that corresponds to unix.debian without much controversy, I hope, and then actually link to the more comprehensive third-party repositories if we decide to start calling out the third-party things.
There was a problem hiding this comment.
The Debian page could mention Ubuntu too (and maybe mention i.e. Ondrej's repo since it covers more versions than the Debian/Ubuntu packages?).
| <h2>Binaries</h2> | ||
|
|
||
| <p> | ||
| <a href="https://windows.php.net/download/">Binaries are available for |
There was a problem hiding this comment.
Should probably remove the Windows download links below if we link it up here.
There was a problem hiding this comment.
I'm not worried about the redundancy, and the later links go to the specific #id for the corresponding version.
|
|
||
| <ul> | ||
| <li> | ||
| <a href="/manual/install.unix.php">Installation instructions for Unix systems</a> |
There was a problem hiding this comment.
This is for building from source and should be put below, and probably made more obvious on the linked page itself that it's for building from source and not likely the user's first choice.
There was a problem hiding this comment.
Yeah, see my response to @cmb69 earlier. This part of the documentation should be re-jiggered a bit to be more binary/package forward.
| <a href="https://windows.php.net/download/">Binaries are available for | ||
| Microsoft Windows</a>. The PHP project does not currently release binary packages | ||
| for other platforms such as Linux or macOS, but they are packaged by distributions | ||
| and other providers. For more information, see: |
There was a problem hiding this comment.
We should be mentioning them here perhaps?
There was a problem hiding this comment.
I'm not sure what you mean by "them".
There was a problem hiding this comment.
The distributions for PHP from third parties.
There was a problem hiding this comment.
I don't think we want to link from this page to those, but I hope we can get agreement to start putting some of that sort of information in the documentation.
|
Forgot to check for other reviews before I hit send; I see Christoph has covered a lot of the same points I have at least. |
|
Started working on the documentation side of this here: php/doc-en#3763 |
|
This was inspired by this GitHub issue and related discussion on the Foundation Slack channel. |
|
Documentation changes landed, so merging this. |
No description provided.