Call all involved class on TypeSpecifierAwareExtension #3882
+30
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aticMethodTypeSpecifyingExtension For the moment, we only want to try a modification to see if existing tests passed. The next steps is to implement a test to reproduce the error then we'll re-implement the modification for real.
staabm
reviewed
Mar 15, 2025
| @@ -519,19 +519,28 @@ public function specifyTypesInCondition( | |||
| $methodReflection = $scope->getMethodReflection($methodCalledOnType, $expr->name->name); | |||
| if ($methodReflection !== null) { | |||
| $referencedClasses = $methodCalledOnType->getObjectClassNames(); | |||
There was a problem hiding this comment.
I think this can be simplified using getObjectClassReflections instead of getObjectClassNames.
that way you no longer need the reflectionProvider as you already get the ClassReflections returned.
(same for static call)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12741
For the moment, we only want to try a modification to see if existing tests passed. The next steps is to implement a test to reproduce the error then we'll re-implement the modification for real.
cc @ChinaskiJr