Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1094 Add Python 3.13 support #1104

Merged
merged 4 commits into from
Oct 20, 2024
Merged

1094 Add Python 3.13 support #1104

merged 4 commits into from
Oct 20, 2024

Conversation

dantownsend
Copy link
Member

Resolves #1094

@dantownsend dantownsend added the enhancement New feature or request label Oct 18, 2024
@dantownsend
Copy link
Member Author

It looks like asyncpg doesn't support Python 3.13 yet.

It looks like it will soon though:

MagicStack/asyncpg#1181

For now, this PR is blocked.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.50%. Comparing base (d1b0bb1) to head (3ea0a68).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (d1b0bb1) and HEAD (3ea0a68). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d1b0bb1) HEAD (3ea0a68)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage   88.45%   79.50%   -8.95%     
==========================================
  Files         116      116              
  Lines        8608     8608              
==========================================
- Hits         7614     6844     -770     
- Misses        994     1764     +770     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend
Copy link
Member Author

The only remaining issue is BlackSheep doesn't have Python 3.13 wheels at the moment:

Neoteroi/BlackSheep#515

We can run the integration tests in Python 3.12 for now, and I'll create a follow up issue.

@dantownsend dantownsend merged commit 265b0c2 into master Oct 20, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Python 3.13 support
2 participants