-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] large transactions don't block watermark advancing #10526
[RFC] large transactions don't block watermark advancing #10526
Conversation
Signed-off-by: zhangjinpeng87 <[email protected]>
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10526 +/- ##
================================================
+ Coverage 57.4842% 57.5333% +0.0491%
================================================
Files 849 849
Lines 126099 126099
================================================
+ Hits 72487 72549 +62
+ Misses 48195 48136 -59
+ Partials 5417 5414 -3 |
Signed-off-by: zhangjinpeng87 <[email protected]>
Signed-off-by: zhangjinpeng87 <[email protected]>
@zhangjinpeng87: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Co-authored-by: CharlesCheung <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #10525
What is changed and how it works?
Propose a better watermark mechanism to advancing watermark smoothly when there are large transactions ongoing in upstream TiDB cluster.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note