Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] rename ResolvedTS to Watermark #10872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangjinpeng87
Copy link
Contributor

What problem does this PR solve?

Issue Number: close tikv/tikv#16708

What is changed and how it works?

Rename ResolvedTS to a more understandable name Watermark.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

Signed-off-by: zhangjinpeng87 <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 2, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@ti-chi-bot ti-chi-bot bot added the affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. label Apr 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 2, 2024

@zhangjinpeng87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-engine-integration-test 33b55dd link true /test engine-integration-test
jenkins-ticdc/verify 33b55dd link true /test verify
pull-cdc-integration-pulsar-test 33b55dd link true /test cdc-integration-pulsar-test
pull-cdc-integration-mysql-test 33b55dd link true /test cdc-integration-mysql-test
pull-cdc-integration-storage-test 33b55dd link true /test cdc-integration-storage-test
pull-dm-integration-test 33b55dd link true /test dm-integration-test
pull-cdc-integration-kafka-test 33b55dd link true /test cdc-integration-kafka-test
pull-dm-compatibility-test 33b55dd link true /test dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

ti-chi-bot bot commented Apr 8, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. do-not-merge/needs-linked-issue needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ResolvedTS to a understandable name
1 participant