Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* : upgrade go to 1.23 #11607

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Conversation

Benjamin2037
Copy link
Contributor

@Benjamin2037 Benjamin2037 commented Sep 20, 2024

What problem does this PR solve?

Issue Number: close #11606

Upgrade golang to version 1.23 

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 20, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2024
@Benjamin2037
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Oct 8, 2024
@Benjamin2037
Copy link
Contributor Author

/retest

@purelind
Copy link
Collaborator

purelind commented Oct 8, 2024

/retest

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added area/engine Issues or PRs related to Dataflow Engine. and removed approved labels Oct 8, 2024
@purelind
Copy link
Collaborator

purelind commented Oct 8, 2024

/test cdc-integration-pulsar-test

@purelind
Copy link
Collaborator

purelind commented Oct 8, 2024

/test engine-integration-test

1 similar comment
@Benjamin2037
Copy link
Contributor Author

/test engine-integration-test

Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2024

@Benjamin2037: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-pulsar-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify
  • /test wip-pull-build
  • /test wip-pull-check
  • /test wip-pull-unit-test-cdc
  • /test wip-pull-unit-test-dm
  • /test wip-pull-unit-test-engine

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify
  • pingcap/tiflow/pull_cdc_integration_kafka_test
  • pingcap/tiflow/pull_cdc_integration_pulsar_test
  • pingcap/tiflow/pull_cdc_integration_storage_test
  • pingcap/tiflow/pull_cdc_integration_test
  • pingcap/tiflow/pull_dm_compatibility_test
  • pingcap/tiflow/pull_dm_integration_test
  • pingcap/tiflow/pull_engine_integration_test

In response to this:

/test engine-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GMHDBJD GMHDBJD self-requested a review October 8, 2024 13:10
Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 9, 2024
@Benjamin2037
Copy link
Contributor Author

Benjamin2037 commented Oct 9, 2024

For golangci-lint, it is not work well with go 1.23, I found errcheck will cause panic of golangci-lint. Also in go 1.23, there are more strict for lint rules, I skip some check because of fix them need more workload and time. left them to later. @hicqu @GMHDBJD
#8a370da

@purelind
Copy link
Collaborator

purelind commented Oct 9, 2024

/test dm-integration-test

@Benjamin2037
Copy link
Contributor Author

/test cdc-integration-storage-test

@Benjamin2037
Copy link
Contributor Author

/test engine-integration-test

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.2650%. Comparing base (45c831a) to head (335ea64).
Report is 9 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.8532% <ø> (-1.3789%) ⬇️
dm 50.0914% <ø> (-0.9420%) ⬇️
engine 53.2027% <ø> (-10.1923%) ⬇️
Flag Coverage Δ
unit 55.2650% <ø> (-2.2121%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11607        +/-   ##
================================================
- Coverage   57.4771%   55.2650%   -2.2121%     
================================================
  Files           851       1001       +150     
  Lines        126539     136162      +9623     
================================================
+ Hits          72731      75250      +2519     
- Misses        48407      55422      +7015     
- Partials       5401       5490        +89     

Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, hicqu, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 14:44:52.551798255 +0000 UTC m=+970847.972011267: ☑️ agreed by yudongusa.
  • 2024-10-09 03:27:11.237967966 +0000 UTC m=+1016586.658180976: ☑️ agreed by hicqu.

@Benjamin2037 Benjamin2037 removed the request for review from GMHDBJD October 9, 2024 03:31
@ti-chi-bot ti-chi-bot bot merged commit 8532fab into pingcap:master Oct 9, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go to 1.23
5 participants