Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ddl_puller.go: fix DDLs are ignored when schema versions are out of order #11733

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wlwilliamx
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11714

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 8, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign charlescheung96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1487%. Comparing base (1da37a2) to head (880e28f).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6424% <100.0000%> (+0.0095%) ⬆️
dm 50.0288% <ø> (-0.0154%) ⬇️
engine 53.2110% <ø> (-0.0170%) ⬇️
Flag Coverage Δ
unit 55.1487% <100.0000%> (-0.0036%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11733        +/-   ##
================================================
- Coverage   55.1522%   55.1487%   -0.0036%     
================================================
  Files          1001       1001                
  Lines        136524     136520         -4     
================================================
- Hits          75296      75289         -7     
- Misses        55718      55720         +2     
- Partials       5510       5511         +1     

@wlwilliamx
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DDL ignored by ddl job finishedTs less than puller resolvedTs
1 participant