Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ticdc): modify generated column test #11737

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wk989898
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #11704

What is changed and how it works?

enable storage sink and pulsar sink.

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wk989898, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024
@wk989898
Copy link
Collaborator Author

/retest

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1504%. Comparing base (64decf6) to head (028dae3).

Additional details and impacted files
Components Coverage Δ
cdc 59.6250% <ø> (+0.0448%) ⬆️
dm 50.0442% <ø> (-0.0231%) ⬇️
engine 53.2449% <ø> (+0.0112%) ⬆️
Flag Coverage Δ
unit 55.1504% <ø> (+0.0146%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11737        +/-   ##
================================================
+ Coverage   55.1358%   55.1504%   +0.0146%     
================================================
  Files          1001       1001                
  Lines        136521     136521                
================================================
+ Hits          75272      75292        +20     
+ Misses        55740      55720        -20     
  Partials       5509       5509                

@wk989898
Copy link
Collaborator Author

/check-issue-triage-complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant