Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config(ticdc): deprecate changefeed level config enable-old-value #9224

Merged
merged 26 commits into from
Sep 5, 2023
Merged

config(ticdc): deprecate changefeed level config enable-old-value #9224

merged 26 commits into from
Sep 5, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Jun 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9667

What is changed and how it works?

  • remove the enable-old-value from the changefeed configuration.
  • remove all reference about this variable

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

deprecate the changefeed level `enable-old-value` configuration, always is true

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 31, 2023
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-mysql-test

@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand 3AceShowHand changed the title [DNM] config(ticdc): deprecate changefeed level config enable-old-value config(ticdc): deprecate changefeed level config enable-old-value Sep 1, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 5, 2023
@asddongmen
Copy link
Contributor

Finally.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-05 02:45:37.968329117 +0000 UTC m=+2413502.517345104: ☑️ agreed by asddongmen.
  • 2023-09-05 04:11:54.806092976 +0000 UTC m=+2418679.355108963: ☑️ agreed by sdojjy.

@3AceShowHand 3AceShowHand removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit e28b004 into pingcap:master Sep 5, 2023
3 of 4 checks passed
@CharlesCheung96 CharlesCheung96 mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy sdojjy approved these changes

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate the changefeed level enable-old-value configuration
3 participants
@3AceShowHand @asddongmen @sdojjy