I18N-1323 - Update Mojito CLI to use OpenAPI spec for rest calls #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarKhaos
force-pushed
the
I18N-1323_P3
branch
3 times, most recently
from
72265a9 to
5f8b939
Compare
DarKhaos
commented
Feb 3, 2025
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.box.l10n.mojito</groupId> | ||
| <artifactId>mojito-restclient</artifactId> |
DarKhaos
commented
Feb 3, 2025
| import org.springframework.web.client.HttpClientErrorException; | ||
|
|
||
| @Component | ||
| public class HttpClientErrorExceptionHelper { |
There was a problem hiding this comment.
Moved classes from restclient module to cli module
DarKhaos
commented
Feb 3, 2025
| @@ -0,0 +1,7 @@ | |||
| package com.box.l10n.mojito.cli.apiclient.exception; | |||
|
|
|||
| public class AssetNotFoundException extends ResourceNotFoundException { | |||
There was a problem hiding this comment.
Moved exception classes from restclient module to cli module
DarKhaos
commented
Feb 3, 2025
| import org.springframework.web.util.UriComponentsBuilder; | ||
|
|
||
| @Component | ||
| public class AuthenticatedRestTemplate { |
There was a problem hiding this comment.
Moved authentication classes from restclient module to cli module
byronantak
reviewed
Feb 4, 2025
cli/src/main/java/com/box/l10n/mojito/cli/apiclient/PollableTaskWsApiProxy.java
Show resolved
Hide resolved
Generate code from open API specification and reuse the generated models and clients
DarKhaos
force-pushed
the
I18N-1323_P3
branch
from
5f8b939 to
e175c03
Compare
maallen
reviewed
Feb 5, 2025
|
|
||
| /** */ | ||
| public class PseudoLocCommandTest extends CLITestBase { | ||
|
|
||
| /** logger */ | ||
| static Logger logger = LoggerFactory.getLogger(PseudoLocCommandTest.class); | ||
|
|
||
| @Autowired RepositoryClient repositoryClient; |
There was a problem hiding this comment.
Does this not need a replacement? Was it unused previously?
| @@ -30,12 +28,8 @@ public class PerformanceSanboxTest extends CLITestBase { | |||
|
|
|||
| static int NUMBER_OF_TEXTUNITS = 10000; | |||
|
|
|||
| @Autowired RepositoryClient repositoryClient; | |||
| @Autowired RepositoryRepository repositoryRepository; | ||
|
|
||
| @Autowired AssetClient assetClient; |
| @@ -65,8 +64,6 @@ public class CLITestBase extends IOTestBase { | |||
|
|
|||
| @Autowired ResttemplateConfig resttemplateConfig; | |||
|
|
|||
| @Autowired RepositoryClient repositoryClient; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate code from open API specification and reuse the generated models and clients