-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes UDPMux IPv4/IPv6 aware #431
Conversation
Codecov Report
@@ Coverage Diff @@
## master pion/webrtc#431 +/- ##
==========================================
- Coverage 78.92% 78.71% -0.21%
==========================================
Files 34 34
Lines 3886 3914 +28
==========================================
+ Hits 3067 3081 +14
- Misses 634 642 +8
- Partials 185 191 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
e3246b1
to
c8f5438
Compare
@braginini I just added you to the Pion org. Would love your opinion on this! Since you have been improving this area as well. |
@Antonito woah this is fantastic! Awesome work, really exciting that we got this fixed so quickly :) This is an approve from me. Worth waiting for @davidzhao @braginini, but if they are busy my vote is API breakage + merge! |
Thanks a lot for the quick feedback! Really excited to get this landed, it's been an issue for a while on my SFU – I wasn't sure how to fix it, until I read your TCP PR 😁 I'll give it a couple hours and will break the API+merge if no new feedback :) |
c8f5438
to
5161437
Compare
With @braginini approval I am all for it! Feel free to tag new ice/webrtc versions as well @Antonito ! |
5161437
to
2adf168
Compare
UDPMux before only worked with UDP4 traffic. UDP6 traffic would simply be ignored. This commit implements 2 connections per ufrag. When requesting a connection for a ufrag the user must specify if they want IPv4 or IPv6. Relates to pion/webrtc#1915
2adf168
to
fafa43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Antonito |
@jech will be happy :)
He will :-)
|
UDPMux before only worked with UDP4 traffic.
UDP6 traffic would simply be ignored.
This commit implements 2 connections per ufrag. When requesting a
connection for a ufrag the user must specify if they want IPv4 or IPv6.
Relates to #518
This is basically a port of #424 to UDPMux
I tested it on an IPv6-only network, on which I was previously unable to connect to a SFU. It seems to work great so far.