Add methods to add and remove extensions #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeTurki
force-pushed
the
impr/add-remove-extension
branch
from
bf9c7ed to
8e1c34f
Compare
|
See #759 |
JoeTurki
force-pushed
the
impr/add-remove-extension
branch
from
8e1c34f to
60cb55e
Compare
Added `AddExtension` and `RemoveExtension` methods to `ICECandidate`, allowing extensions to be managed dynamically. Ensure that `TCPType` is stored in one place (candidate.TCPType)
JoeTurki
force-pushed
the
impr/add-remove-extension
branch
from
60cb55e to
47dad55
Compare
This was referenced Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
AddExtensionandRemoveExtensionmethods toICECandidate, allowing extensions to be managed dynamically.Ensure that
TCPTypeis stored in one place (candidate.TCPType)Reference issue
This is required for #757 and by extension pion/webrtc#2993 and some other..