Update golangci-lint and ensure the code passes make lint/go

[karamaru-alpha]

What this PR does / why we need it:

• Update golangci-lint v1.46.2 to v1.55.2 in order to support Go 1.20(v1.51.0~)
• Ensure the code passes golangci-lint
  • Currently, the make lint/go command does not output any errors.
  • Temporarily disabled a few linters(errcheck,goerr113,gosec) that seemed time-consuming to address in order to expedite the implementation of CI. I will handle them in the near future.

Resolved errors from the `make lint/go` command

pkg/app/ops/deploymentchaincontroller/controller.go:133:79: (*DeploymentChainController).syncDeploymentChains - result 0 (error) is always nil (unparam)
func (d *DeploymentChainController) syncDeploymentChains(ctx context.Context) error {
                                                                              ^
pkg/app/piped/appconfigreporter/appconfigreporter.go:236:112: (*Reporter).findOutOfSyncRegisteredApps - result 1 (error) is always nil (unparam)
func (r *Reporter) findOutOfSyncRegisteredApps(repoPath, repoID, headCommit string) ([]*model.ApplicationInfo, error) {
                                                                                                               ^
pkg/app/piped/cmd/piped/piped.go:700:3: singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
		switch sm.Type {
		^
pkg/app/piped/controller/controller.go:291:56: (*controller).syncPlanners - result 0 (error) is always nil (unparam)
func (c *controller) syncPlanners(ctx context.Context) error {
                                                       ^
pkg/app/piped/controller/controller.go:509:58: (*controller).syncSchedulers - result 0 (error) is always nil (unparam)
func (c *controller) syncSchedulers(ctx context.Context) error {
                                                         ^
pkg/app/piped/controller/controller.go:556:13: appendAssign: append result not assigned to the same slice (gocritic)
	targets := append(runnings, planneds...)
	           ^
pkg/app/piped/driftdetector/cloudrun/detector.go:125:47: (*detector).check - result 0 (error) is always nil (unparam)
func (d *detector) check(ctx context.Context) error {
                                              ^
pkg/app/piped/driftdetector/kubernetes/detector.go:123:47: (*detector).check - result 0 (error) is always nil (unparam)
func (d *detector) check(ctx context.Context) error {
                                              ^
pkg/app/piped/driftdetector/terraform/detector.go:124:47: (*detector).check - result 0 (error) is always nil (unparam)
func (d *detector) check(ctx context.Context) error {
                                              ^
pkg/app/piped/executor/analysis/analysis.go:119:47: `analysises` is a misspelling of `analyses` (misspell)
				// Stop the context to cancel all running analysises.
				                                          ^
pkg/app/piped/executor/kubernetes/kubernetes.go:311:2: Consider pre-allocating `out` (prealloc)
	var out []provider.Manifest
	^
pkg/app/piped/executor/kubernetes/kubernetes.go:325:2: Consider pre-allocating `out` (prealloc)
	var out []provider.Manifest
	^
pkg/app/piped/executor/kubernetes/kubernetes_test.go:1021:3: assignOp: replace `out.Key.Namespace = out.Key.Namespace + "+"` with `out.Key.Namespace += "+"` (gocritic)
		out.Key.Namespace = out.Key.Namespace + "+"
		^
pkg/app/piped/livestatereporter/cloudrun/report.go:99:56: (*reporter).flushSnapshots - result 0 (error) is always nil (unparam)
func (r *reporter) flushSnapshots(ctx context.Context) error {
                                                       ^
pkg/app/piped/livestatereporter/kubernetes/reporter.go:112:56: (*reporter).flushSnapshots - result 0 (error) is always nil (unparam)
func (r *reporter) flushSnapshots(ctx context.Context) error {
                                                       ^
pkg/app/piped/livestatestore/kubernetes/appnodes.go:87:55: `(*appNodes).deleteManagingResource` - `key` is unused (unparam)
func (a *appNodes) deleteManagingResource(uid string, key provider.ResourceKey, now time.Time) (model.KubernetesResourceStateEvent, bool) {
                                                      ^
pkg/app/piped/livestatestore/kubernetes/appnodes.go:141:55: `(*appNodes).deleteDependedResource` - `key` is unused (unparam)
func (a *appNodes) deleteDependedResource(uid string, key provider.ResourceKey, now time.Time) (model.KubernetesResourceStateEvent, bool) {
                                                      ^
pkg/app/piped/livestatestore/kubernetes/reflector.go:153:27: `(*reflector).start` - `ctx` is unused (unparam)
func (r *reflector) start(ctx context.Context) error {
                          ^
pkg/app/piped/notifier/slack.go:353:32: `truncateText` - `max` always receives `8` (unparam)
func truncateText(text string, max int) string {
                               ^
pkg/app/piped/planner/kubernetes/kubernetes.go:344:2: Consider pre-allocating `out` (prealloc)
	var out []provider.Manifest
	^
pkg/app/piped/planpreview/builder.go:304:205: `(*builder).findTriggerApps` - result `err` is always `nil` (unparam)
func (b *builder) findTriggerApps(ctx context.Context, repo git.Repo, apps []*model.Application, headCommit string) (triggerApps []*model.Application, failedResults []*model.ApplicationPlanPreviewResult, err error) {
                                                                                                                                                                                                            ^
pkg/app/piped/platformprovider/kubernetes/hasher.go:50:3: ifElseChain: rewrite if-else to switch statement (gocritic)
		if m.Key.IsConfigMap() {
		^
pkg/app/piped/platformprovider/kubernetes/resourcekey.go:24:5: ST1003: var builtInApiVersions should be builtInAPIVersions (stylecheck)
var builtInApiVersions = map[string]struct{}{
    ^
pkg/app/piped/platformprovider/kubernetes/state.go:427:3: S1023: redundant `return` statement (gosimple)
		return
		^
pkg/app/piped/trigger/trigger.go:477:45: `(*Trigger).notifyDeploymentTriggered` - `ctx` is unused (unparam)
func (t *Trigger) notifyDeploymentTriggered(ctx context.Context, appCfg *config.GenericApplicationSpec, d *model.Deployment) {
                                            ^
pkg/app/server/apikeyverifier/verifier.go:89:32: `(*Verifier).checkAPIKey` - `ctx` is unused (unparam)
func (v *Verifier) checkAPIKey(ctx context.Context, apiKey *model.APIKey, id, key string) error {
                               ^
pkg/crypto/hybrid.go:48: File is not `goimports`-ed with -local github.com/pipe-cd/pipecd (goimports)
//   RSA ciphertext length || RSA ciphertext || AES ciphertext
pkg/git/client.go:271:19: `retryCommand` - `retries` always receives `3` (unparam)
func retryCommand(retries int, interval time.Duration, logger *zap.Logger, commander func() ([]byte, error)) (out []byte, err error) {
                  ^
pkg/git/client_test.go:119:25: `(*faker).repoDir` - `org` always receives `org` (`"test-repo-org"`) (unparam)
func (f *faker) repoDir(org, repo string) string {

TODO (another PR)

• Integrate golangci-lint into GitHub Actions
• Resolve errcheck,goerr113,gosec errors

Which issue(s) this PR fixes:

Part of #4566

Does this PR introduce a user-facing change?:

• How are users affected by this change:
• Is this breaking change:
• How to migrate (if breaking change):

[karamaru-alpha]

Delete "deadcode" because this linter is deprecated.
cf. golangci/golangci-lint#1841

[karamaru-alpha]

The configuration method of "depguard" has been changed.
cf. https://golangci-lint.run/usage/linters/#depguard

[karamaru-alpha]

Since I didn't think the following error was particularly harmful, I ignored "appendAssign".

pkg/app/piped/controller/controller.go:556:13: appendAssign: append result not assigned to the same slice (gocritic)
targets := append(runnings, planneds...)

cf. go-critic/go-critic#865 (comment)

[karamaru-alpha]

Ignore "unparam" to resolve the following error.

pkg/app/piped/notifier/slack.go:353:32: truncateText - max always receives 8 (unparam)
func truncateText(text string, max int) string {

It is impossible to remove the "always receives X" check by config currently.
cf. mvdan/unparam#31

[karamaru-alpha]

I have decided to temporarily ignore linters that present numerous errors, seem time-consuming to resolve, or require discussion. This is because I believe it's more important to integrate golangci-lint into GitHub Actions to prevent a continuous increase in errors in the future.

[khanhtc1202]

got it, thanks 👍

[codecov]

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (89fb203) 30.81% compared to head (b92198d) 30.84%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4656      +/-   ##
==========================================
+ Coverage   30.81%   30.84%   +0.02%     
==========================================
  Files         221      221              
  Lines       25941    25935       -6     
==========================================
+ Hits         7995     7999       +4     
+ Misses      17296    17286      -10     
  Partials      650      650              

Files	Coverage Δ
pkg/app/piped/executor/kubernetes/kubernetes.go	58.59% <100.00%> (ø)
pkg/app/piped/executor/kubernetes/traffic.go	24.84% <100.00%> (ø)
pkg/app/piped/notifier/slack.go	3.57% <ø> (ø)
pkg/app/piped/planner/kubernetes/kubernetes.go	52.40% <100.00%> (ø)
...kg/app/piped/platformprovider/kubernetes/hasher.go	64.70% <100.00%> (ø)
...p/piped/platformprovider/kubernetes/resourcekey.go	27.85% <100.00%> (ø)
pkg/app/piped/platformprovider/kubernetes/state.go	0.00% <ø> (ø)
pkg/app/server/apikeyverifier/verifier.go	70.45% <100.00%> (ø)
pkg/crypto/hybrid.go	50.63% <ø> (ø)
pkg/git/client.go	47.67% <ø> (ø)
... and 6 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kentakozuka]

LGTM 👍
Thanks!