Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunningDeploymentSource and TargetDeploymentSource to ExecuteStageRequest #5606

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 26, 2025

What this PR does:

as title

Why we need it:

We need these to execute deployment stages such as K8S_SYNC and K8S_ROLLBACK.

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi marked this pull request as ready for review February 26, 2025 08:19
@Warashi Warashi enabled auto-merge (squash) February 26, 2025 08:21
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.51%. Comparing base (855aa0a) to head (558a53f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5606   +/-   ##
=======================================
  Coverage   26.51%   26.51%           
=======================================
  Files         474      474           
  Lines       50496    50505    +9     
=======================================
+ Hits        13388    13393    +5     
- Misses      36047    36048    +1     
- Partials     1061     1064    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit c2aca82 into master Feb 26, 2025
16 of 18 checks passed
@Warashi Warashi deleted the deployment-plugin-sdk branch February 26, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants