Updated Vite support #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bildungsroman thanks for putting this together! I'll try and get round to reviewing this next week |
Thanlks @Zyie, this is pretty urgent for my team so I would definitely appreciate a quick review! |
|
Hey @bildungsroman thanks for all the hard work on this PR. I am going to close this in favor of #22 as the storybook v8 part of this PR was not fully implemented. I've released |
|
Awesome, thanks so much! I'll import alpha today and try it out |
|
LGTM! Please let me know when it's merged so I can import it properly into my package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Vite, closes #1 and #14 .
This builds off of @GregVGW's excellent long-open PR and updates libraries for Pixi 8 and Storybook 8 as well as adding Vite support to the README.