Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use node 20 #23

Merged
merged 2 commits into from
Feb 4, 2025
Merged

ci: use node 20 #23

merged 2 commits into from
Feb 4, 2025

Conversation

bjohansebas
Copy link
Contributor

I had forgotten to update the Node.js version in the workflow, that's why the build of the statusboard was failing. Now it uses version 20 and works correctly.

@bjohansebas
Copy link
Contributor Author

All the tests pass 🥳

@wesleytodd
Copy link
Member

Yep, once the waiting period for review is done we can merge.

@bjohansebas
Copy link
Contributor Author

@wesleytodd, can you merge this?

@wesleytodd wesleytodd merged commit f299c3e into pkgjs:main Feb 4, 2025
6 checks passed
@bjohansebas bjohansebas deleted the update-node-version branch February 4, 2025 16:39
@bjohansebas
Copy link
Contributor Author

@wesleytodd, you need to do the same thing you did in the Express repository.

@wesleytodd
Copy link
Member

Sorry what is that? Can you clarify?

@bjohansebas
Copy link
Contributor Author

Change the repository to deploy with GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants