Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t break $XDG_DATA_DIRS #76

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Don’t break $XDG_DATA_DIRS #76

merged 1 commit into from
Sep 6, 2024

Conversation

mxcl
Copy link
Member

@mxcl mxcl commented Sep 6, 2024

Fixes #70

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10743721208

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 82.932%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useShellEnv.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 10737309581: -0.06%
Covered Lines: 2442
Relevant Lines: 2880
💛 - Coveralls

@mxcl mxcl requested a review from jhheider September 6, 2024 19:07
jhheider
jhheider approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@jhheider jhheider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@mxcl mxcl merged commit 572154c into main Sep 6, 2024
5 of 8 checks passed
@mxcl mxcl deleted the fixes/70 branch September 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhheider jhheider jhheider approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libpkgx sets XDG_DATA_DIRS in some cases
3 participants
@mxcl @coveralls @jhheider