Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flexible request body parser #434

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Flexible request body parser #434

wants to merge 4 commits into from

Conversation

tokuhirom
Copy link
Member

No description provided.

@tokuhirom
New flexible request body parser.
83ffe65 
- It's 100% compatible with older versions.
- User can add any body parser by himself.
- HTTP::MultiPartParser & URL::Encode is faster than HTTP::Body.
@tokuhirom
Make body parser as an object, instead of coderef.
a3b74e6 
- Remove backward compatible layer for HTTP::Body.
@tokuhirom
BodyParser::MultiPart: parse headers.
1fac96a
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.78%) when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

miyagawa
miyagawa reviewed Oct 30, 2013
View reviewed changes
lib/Plack/BodyParser/JSON.pm
use strict;
use warnings;
use utf8;
use 5.010_001;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. My vim snippet injected this. I removed this at 4a80f4e.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.77%) when pulling 4a80f4e on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

@miyagawa
Copy link
Member

I saw http://search.cpan.org/~kazeburo/HTTP-Entity-Parser-0.12/lib/HTTP/Entity/Parser.pm and would love to replace HTTP::Body with a faster implementation like this. Is it still viable to update and merge this? cc @kazeburo

See also: @chansen's URL::Encode::XS, HTTP::MessageParser and HTTP::MultipartParser.

cc @avar

@miyagawa
Copy link
Member

Duh, I completely forgot this PR and re-implemented everything with #537

@kazeburo kazeburo mentioned this pull request Nov 16, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tokuhirom @coveralls @miyagawa