Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split relay roles per server type #116

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

dcadenas
Copy link
Contributor

We used to maintain a single relay and had to reuse the setup for the nostr-rs-relay while working under the Olympics deadline. Now that the new relay is live, we need to make some changes for better maintainability.

This refactor introduces separate inventories and roles for strfry relays and nostr-rs-relay relays. Although they are similar, there are differences in directories and Docker images. In future work, more differences may appear, so this structure allows us to manage those changes for each type of relay more cleanly.

I also removed unused config settings, which are now handled through their corresponding Docker repositories' automated deployments.

@dcadenas dcadenas requested a review from mplorentz July 31, 2024 11:51
@dcadenas
Copy link
Contributor Author

This is for #117

hosts:
olympics2024.nos.social:
relay_image_tag: olympics_latest
dev-olympics2024.nos.social:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can nix dev-olympics2024.nos.social, since we are trying to move to personal dev boxes rather than having one for every service. Is there an actual droplet here that we should tear down?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I feel weird about putting the olympics2024.nos.social relay in this inventory file too, because it wasn't deployed with the nostr-rs-relay playbook and tbh I'm not totally sure what would happen if we ran it on the live box. Maybe we can leave the vars in here but leave hosts empty with a comment that we don't have any production servers using this role right now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with that. I didn't know we wanted personal servers but that's also fine. I had asked @gergelypolonkai to create a dev-olympics2024.nos.social box but we can just change the name to daniel.dev.nos.social instead. I assume the idea is reusing those for every type of test on other unrelated projects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added my personal host for the new inv and left olympics as before so the old inv and role works as it was. I have a relay deployed at my test ip but it still needs to have a dns name for the ssl to work, I think @gergelypolonkai is working on that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah sorry I didn't communicate on the personal dev boxes. We were basically doubling our DO costs by having a dev version of each service and we really only used them to test ansible scripts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 was this not being used? Same question for allowed_rules.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, it's living solely in the repo here, much easier to update.

@dcadenas dcadenas requested a review from mplorentz August 2, 2024 11:09
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for cleaning this up a bit.

@dcadenas dcadenas merged commit 7d51a8f into main Aug 6, 2024
@dcadenas dcadenas deleted the split_relay_roles_per_server_type branch August 6, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants