Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document .gitignore. Add .DS_Store to it while at it. #1025

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

document .gitignore. Add .DS_Store to it while at it. #1025

wants to merge 3 commits into from

Conversation

JacquesCarette
Copy link
Contributor

As per title.

@JacquesCarette
Copy link
Contributor Author

So it seems to pre-commit hook didn't like my changes to .gitignore. Are the rules to obey written down somewhere?

@wenkokke
Copy link
Collaborator

The pre-commit setup sorts it alphabetically, which is incorrect given that .gitignore exclusions and inclusions are order-dependent, so that should probably be taken out.

(The details are in the pre-commit config file. Follow the links to the various repositories to find out what code each action runs.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacquesCarette @wenkokke