Improve prop typing generation #3220
Merged
+96
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
requested review from
alexcjohnson,
ndrezn,
gvwilson and
emilykl
as code owners
gvwilson
approved these changes
Mar 14, 2025
|
The https://pypi.org/project/stringcase/ package, that is hard dependacy of Dash since this PR can no longer be installed using setuptools >=78, because of the following PR https://github.com/pypa/setuptools/pull/4870. As a result, Dash can no longer be installed with setuptools version >=78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3216
Add:
ignore_propsvariable todash_prop_typing.py, is alist[str]with the name of props to ignore typing generation for all components (set toany). Default to["style"].*key incustom_importsandcustom_propsto apply the prop typing function to all the component that matches.proptypes.jsfootprint.