Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to ignore certain shapes when doing autosize #4365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mitja-p
Copy link

@mitja-p mitja-p commented Nov 19, 2019

In some cases it is useful to ignore some shapes when auto sizing as they might stretch beyond current range on purpose or we do not even care where they are. By adding an option autorange (default: true), we can individually remove some shapes from auto sizing algorithm.

In some cases it is useful to ignore some shapes when auto sizing as they might stretch beyond current range on purpose or we do not even care where they are. By adding an option autorange (default: true), we can individually remove some shapes from auto sizing algorithm.
@mitja-p mitja-p closed this Nov 21, 2019
@mitja-p mitja-p reopened this Oct 18, 2022
@gvwilson gvwilson self-assigned this Jun 10, 2024
@gvwilson
Copy link
Contributor

This pull request has been sitting for a while, so I would like to close it as part of our effort to tidy up our public repositories. I've assigned it to myself to keep track of it; I'll wait until 2024-06-17 for someone to say it's still relevant and they'll to take it on, and otherwise I will close it then. Thanks - @gvwilson

@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added feature something new community community contribution labels Aug 8, 2024
@gvwilson gvwilson changed the title An option to ignore certain shapes when doing autosize add option to ignore certain shapes when doing autosize Aug 9, 2024
@gvwilson gvwilson added the P2 considered for next cycle label Aug 9, 2024
@gvwilson
Copy link
Contributor

@emilykl when you have a sec could you please let us know if this was closed by your earlier autosizing work? thanks - @gvwilson

@emilykl
Copy link
Contributor

emilykl commented Sep 27, 2024

Hi @mitja-p, thank you very much for the contribution.

If I understand correctly, the intention is for the chart developer to be able to specify certain shapes to exclude from axis autorange calculations, is that right?

If so I don't believe this change will have the desired effect. If you want to add a new shape attribute (something like autorangeignore) it should be added in src/components/shapes/attributes.js.

Feel free to also share a code example demonstrating the desired outcome.

@mitja-p
Copy link
Author

mitja-p commented Sep 30, 2024

Yes, that is right. I forgot the exact purpuse, but I think it was for helper lines that should be ignored when doing auto range as they are visual aid and not a thing that needs to be fully visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants