Fix seemingly bugged eldrich hunter capture chance #1358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #1199
Gives a catch rate that is forgiving enough to allow actually filling the amount of captive housing that can be built.
To summarize the change:
currently the chance of capturing an additional captive (Not taking into account additional traits such as sniper)
1 / ((50 * number of captives) - (number of raiders * military research rank))
With the current highest military weapon strength being 10 (without additional traits), this imposes an end-game soft cap on captives/thralls of 1/5th the number of assigned raiders. Where below this soft cap capture is certain, and beyond the soft cap the chance of capture drops off so quickly that you are unlikely to get more than 10 or 20 additional captives no matter how long you were to wait. (the chance of getting your 20th captive past the soft cap is 0.1% per in game day)
The new system instead has a chance of:
(number of raiders * military research rank) / (50 * number of captives)
to obtain a new captive each day.
Which also, given the
<= 0
comparison in the code, seems likely to have been the original intention for this mechanic.Thank you for your time.