Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image grid #666

Merged
merged 6 commits into from
May 23, 2023
Merged

Image grid #666

merged 6 commits into from
May 23, 2023

Conversation

reshmee011
Copy link
Contributor

Q A
New sample? yes

What's in this Pull Request?

Instagram familiar layout using Instagram feeds

Thanks for your contribution! Sharing is caring.

@tecchan1107 tecchan1107 self-assigned this Apr 30, 2023
@tecchan1107
Copy link
Collaborator

Hi @reshmee011 ! Thank you for another sample🤩🤩✨

I'm thinking of processing this pull request after the following Power Automate side is done, as I think it would be better to centralize the Power Automate flow and documentation in one place, is that ok? I am going to remove the Flow zip file included in this pull request and also change the link to the documentation in the README to the README for PnP's Power Automate.
pnp/powerautomate-samples#48

@reshmee011
Copy link
Contributor Author

reshmee011 commented May 16, 2023 via email

@tecchan1107
Copy link
Collaborator

@reshmee011
I took the liberty of thinking that it would be better to relate it to the flow... very sorry...😣
Please let me know if there is any progress!

@reshmee011
Copy link
Contributor Author

No worries.. May be I can make it a generic grid image layout view formatting sample with any links to Instagram or flow, what do you think ?

@tecchan1107
Copy link
Collaborator

@reshmee011
I think that is a great idea! By making a generic sample, it would be easy to apply it to other things, and it would be a sample that many people would find helpful and use! Of course, I think it could also be applied to lists linked to Instagram!

@reshmee011
Copy link
Contributor Author

Hi @tecchan1107

Many thanks for the feedback. I will make it generic then.

Best Regards
Reshmee

@reshmee011
Copy link
Contributor Author

reshmee011 commented May 20, 2023

@tecchan1107 : Hope you are doing well. Apologies for the delay. I have renamed the PR to Image grid and made the sample generic without reliance on the power automate.

@reshmee011 reshmee011 changed the title Instagram Basic Display Image grid May 20, 2023
@tecchan1107 tecchan1107 merged commit 585c0a2 into pnp:master May 23, 2023
@tecchan1107
Copy link
Collaborator

tecchan1107 commented May 23, 2023

Thank you for the great sample and for the fixes! I have merged them, please check the following link.
https://github.com/pnp/List-Formatting/tree/master/view-samples/image-grid

The following tweaks were made when doing the merge. Let me know if you have any questions!

  • Added object-fit property to avoid image smashing. (For more information on the object-fit property, this page may be helpful.)
  • Removed Title column from View requirements since it was not being used.
  • Changed columns Image and Description to required.

Once again, I apologize for the delay and for my self-serving assumption🙇‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants