Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spo web get command and add ESM module instructions #6425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shahzdvp
Copy link

Fixes 'spo web get' command usage in documentation. Closes #5699

This pull request addresses the bug in the documentation where the 'spo web get' command was incorrectly using 'webUrl' instead of 'url' as a parameter. It also adds a note about using ESM modules when including CLI for Microsoft 365 as a dependency in Node.js projects.

Changes made:

  1. Updated the example code to use 'url' instead of 'webUrl' in the 'spo web get' command.
  2. Added a section explaining the need for ESM modules in projects using CLI for Microsoft 365.
  3. Provided an example package.json configuration for a Node.js app using ESM modules.
  4. Included instructions on how to set up and run a project with these configurations.

These changes improve the accuracy of the documentation and provide clearer guidance for developers integrating CLI for Microsoft 365 into their Node.js projects.

@milanholemans
Copy link
Contributor

Thank you, we'll try to review it ASAP!

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Oct 29, 2024

@shahzdvp I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs on programmatically using CLI
3 participants