Refactor action naming #294
Conversation
…pnp#246 (pnp#280) ## 🎯 Aim The aim is to refactor the way start and run commands in integrated VS Code terminal. The idea is to aling the approach by using the dedicated Terminal service which was developed for exactly that. ## ✅ What was done - [X] Removes all direct usage of `terminal` and refactors it to same approach ## 🔗 Related issue Closes: pnp#246
…sions. Closes: pnp#200 (pnp#281) ## 🎯 Aim This PR implements the required settings of issue [pnp#200](pnp#200). ## 📷 Result  ## ✅ What was done Added two settings for the extension: - showServiceIncidentList - showTenantWideExtensions Updated the `TerminalCommandExecuter` extracting the `getExtensionSettings` method and creating a dedicated util file. Updated the `CommandPanel` to keep into account the new settings when loading and showing data. ## 🔗 Related issue Closes: pnp#200 --------- Co-authored-by: Saurabh Tripathi <[email protected]> Co-authored-by: Adam Wójcik <[email protected]> Co-authored-by: Luccas Castro <[email protected]> Co-authored-by: Adam Wójcik <[email protected]>
## 🎯 Aim The aim is to make account and enviroment views more bulletproof and properly display views when CLI command extecution gets rejected due to lack of permission ## 📷 Result  ## ✅ What was done - [X] Added simple error handling to cover the reject case ## 🔗 Related issue Closes: pnp#278
## 🎯 Aim Adding an extra filter to Sample gallery so that we can filter on the extension type. Filter can only be visible when extension type is selected 'Component Type' ## 📷 Result  ## ✅ What was done - [X] Added Extension filter dropdown - [X] Added functionality so that extension filter is only visible when extension is selected in the Component Type dropdown - [X] Added filter functionality so that samples get filtered based on selected value in extension dropdown - [x] Added filter functionality so that samples don't get filtered when extensions dropdown has selected values but extension is not selected in component type dropdown ## 🔗 Related issue Closes: pnp#219
There was a problem hiding this comment.
Unfortunately, this is only part of what needs to be done for this issue. As part of this change we should also align the commands naming (those are present in VS Code when using the F1 and searching for commands for SharePoint Framework Toolkit). We should also align the commands naming to be the same as we see in the actions tree.
Those may be found in the package.json file
https://github.com/pnp/vscode-viva/blob/d241081aa95aea583aa94354c8d0ade82c91ec6b/package.json#L297C4-L310C47
|
@maximkol awesome start. I left a small comment as I think this PR is missing part of implementation that is described in the related issue. Please do give it a recheck 👍 |
Adam-it
force-pushed
the
dev
branch
2 times, most recently
from
d3fe8fc
to
5359569
Compare
|
@maximkol we just had a new major v4 release. Due to this the |
|
@maximkol any updates on this PR? |
🎯 Aim
To update actions naming
📷 Result
✅ What was done
🔗 Related issue
Closes: #287