Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump job and write service refactor #860

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Jun 3, 2022

This attempts to extract the logic in common between GenerateFullDumpJob and GenerateDeltaDumpJob. It also pushes some of that logic onto the writer services MarcRecordWriterService and OaiMarcRecordWriterService, and attempts to have the latter manage its own files.

There are some placeholders for tests of the OaiMarcRecordWriterService; right now tests are failing because something's wrong with the logic to manage files. Everything else should be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant