Dump job and write service refactor #860
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to extract the logic in common between
GenerateFullDumpJob
andGenerateDeltaDumpJob
. It also pushes some of that logic onto the writer servicesMarcRecordWriterService
andOaiMarcRecordWriterService
, and attempts to have the latter manage its own files.There are some placeholders for tests of the
OaiMarcRecordWriterService
; right now tests are failing because something's wrong with the logic to manage files. Everything else should be working.