Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatted code and linting #149

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Add formatted code and linting #149

merged 3 commits into from
Nov 30, 2024

Conversation

mrclmr
Copy link
Contributor

@mrclmr mrclmr commented Nov 29, 2024

No description provided.

@mrclmr mrclmr force-pushed the add-formatted-code-and-linting branch 2 times, most recently from ac0337c to a6ca7e0 Compare November 29, 2024 15:13
@mrclmr mrclmr force-pushed the add-formatted-code-and-linting branch from 7ef9fdb to e308895 Compare November 29, 2024 15:17
@mrclmr
Copy link
Contributor Author

mrclmr commented Nov 29, 2024

Tests run with Go 1.23. I hope this is okay.

@mrclmr
Copy link
Contributor Author

mrclmr commented Nov 29, 2024

Because golangci-lint uses internally the go command in grammars/calculator/calculator.go I needed to remove

/go:build grammars
// +build grammars

Without the build tags the linter works. Maybe it would good if //go:build can be defined in peg file to have it in the generated file. Maybe this is already possible but I couldn't find out how this works.

@pointlander pointlander merged commit bd929c4 into pointlander:master Nov 30, 2024
1 check passed
@mrclmr mrclmr deleted the add-formatted-code-and-linting branch November 30, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrclmr @pointlander