Add showForSingleQuality config to qualitySelector
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it makes sense to show the quality selector even if there is only one quality to select from. This shows the user the current quality for example. But it is also about consistency, so that the user can always expect there to be this selector, otherwise users might be confused by it missing. This is especially relevant if you move the quality selector into a submenu: if the quality selector randomly disappears, the submenu might end up empty, which looks very weird. So in these cases, it is beneficial to just always show it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it makes sense to show the quality selector even if there is only one quality to select from. This shows the user the current quality for example. But it is also about consistency, so that the user can always expect there to be this selector, otherwise users might be confused by it missing. This is especially relevant if you move the quality selector into a submenu: if the quality selector randomly disappears, the submenu might end up empty, which looks very weird. So in these cases, it is beneficial to just always show it.
Once this is accepted, I will open another PR against paella-core to update the documentation.