Create the Shopping Cart Lock app #2326
Conversation
Will demonstrate tomorrow. Don't merge until I do 😁
firmware/application/external/shoppingcart_lock/shoppingcart_lock.hpp
Outdated
Show resolved
Hide resolved
firmware/application/external/shoppingcart_lock/shoppingcart_lock.hpp
Outdated
Show resolved
Hide resolved
firmware/application/external/shoppingcart_lock/shoppingcart_lock.cpp
Outdated
Show resolved
Hide resolved
|
Looks fine, @RocketGod-git tell us if you need help for the formatting. |
|
No worries on the formatting. I'm just working on the sound quality right now. If not correct it won't work so refining the code to pull exact properties from the audio metadata in the wav file. Also, for a future project - but I won't merge until I think it's perfect. Hopefully this weekend. |
If nobody has any ideas to further improve high frequencies of the audio, the hardware may not be capable. I still need to check with line-out to better speaker to make sure it's not just the speaker, but it shouldn't be.
…ill playback seems to be missing higher fq sounds
|
Really cool @RocketGod-git |
|
Yes. I stole their wav files 🙃 |
They also have two more WAV files, but we don't have that system in The Netherlands, hence can't test it :) |
|
I would also rename the wav files to something like "cart_lock" and "cart_unlock" to be less generic than "lock" and "unlock" |
|
Okay, I did review it fully. As I don't have write access to your branch on your repo, I can only ask you to make the changes. Please add these definitions in shoppingcart_lock.hpp Please replace all occurences of lock.wav by shoppingcart_lock_file Please rename sdcard/WAV/lock.wav to sdcard/WAV/shopping_cart_lock.wav Please reindent all project using format-code.sh at the root of the repository Commit all this and we will be able to merge :-) |
|
Ho well. I did it for you |
gullradriel
dismissed
htotoo’s stale review
indent have been done. can't merge without dismissing the requested change
Will demonstrate tomorrow. Don't merge until I do 😁